Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#635): Support isExpanded on KtDrawer #641

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(#635): Support isExpanded on KtDrawer #641

wants to merge 3 commits into from

Conversation

carsoli
Copy link
Contributor

@carsoli carsoli commented Jun 23, 2022

No description provided.

@render
Copy link

render bot commented Jun 23, 2022

Your Render PR Server URL is https://kotti-pr-641.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-caq83hvs437gvhlcqe6g.

@github-actions github-actions bot added the package:kotti-ui @3yourmind/kotti-ui label Jun 23, 2022
@carsoli carsoli added type:enhancement features, etc. priority:3-normal Should be fixed soon autorebase:opt-in Apply this label to enable automatic rebasing labels Jun 23, 2022
@carsoli carsoli force-pushed the 635-support-is-expanded-on-kt-drawer branch from 09cb5de to b20fff7 Compare June 23, 2022 15:09
@FlorianWendelborn FlorianWendelborn force-pushed the 635-support-is-expanded-on-kt-drawer branch 6 times, most recently from 88765af to 015da93 Compare June 24, 2022 12:29
@FlorianWendelborn FlorianWendelborn force-pushed the 635-support-is-expanded-on-kt-drawer branch from 015da93 to cf976e5 Compare June 27, 2022 14:03
@carsoli carsoli force-pushed the 635-support-is-expanded-on-kt-drawer branch from cf976e5 to 015da93 Compare June 27, 2022 14:03
@FlorianWendelborn FlorianWendelborn force-pushed the 635-support-is-expanded-on-kt-drawer branch 3 times, most recently from cb1c39d to b9ad6d9 Compare June 28, 2022 17:06
@FlorianWendelborn FlorianWendelborn added the autorebase:non-rebaseable AutoRebase applies this label when a pull request can't be rebased automatically label Jun 28, 2022
FlorianWendelborn
FlorianWendelborn requested changes Jun 28, 2022
View reviewed changes
packages/documentation/package.json Outdated Show resolved Hide resolved
packages/kotti-ui/source/kotti-style/index.scss
@@ -12,6 +12,7 @@
// Utility classes
@import 'utilities';
@import 'media';
@import 'mixins';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure, but this looks like a no-op.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i moved it under kotti-style, so

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FlorianWendelborn can this be resolved?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seems like a noop

Copy link
Contributor Author

@carsoli carsoli Feb 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you either elaborate on why you think it is or test it?

@carsoli carsoli changed the title 635: Support isExpanded on KtDrawer feat(635): Support isExpanded on KtDrawer Jul 25, 2022
@carsoli carsoli force-pushed the 635-support-is-expanded-on-kt-drawer branch from b9ad6d9 to 3dcd403 Compare July 25, 2022 11:28
@FlorianWendelborn FlorianWendelborn removed the autorebase:non-rebaseable AutoRebase applies this label when a pull request can't be rebased automatically label Jul 25, 2022
@FlorianWendelborn FlorianWendelborn force-pushed the 635-support-is-expanded-on-kt-drawer branch 5 times, most recently from 1178f95 to bc552ab Compare November 29, 2022 11:28
@FlorianWendelborn FlorianWendelborn force-pushed the 635-support-is-expanded-on-kt-drawer branch 5 times, most recently from 41bfafa to 18c0352 Compare December 9, 2022 14:27
@FlorianWendelborn FlorianWendelborn force-pushed the 635-support-is-expanded-on-kt-drawer branch 3 times, most recently from 86d32b9 to 8a79034 Compare December 14, 2022 11:05
@FlorianWendelborn FlorianWendelborn force-pushed the 635-support-is-expanded-on-kt-drawer branch from 8a79034 to 2285841 Compare December 19, 2022 15:09
@FlorianWendelborn FlorianWendelborn force-pushed the 635-support-is-expanded-on-kt-drawer branch 2 times, most recently from c075a6c to ca86592 Compare December 30, 2022 01:18
@carsoli carsoli changed the title feat(635): Support isExpanded on KtDrawer feat(#635): Support isExpanded on KtDrawer Feb 1, 2023
@carsoli carsoli force-pushed the 635-support-is-expanded-on-kt-drawer branch from ca86592 to 7adaca5 Compare February 1, 2023 10:53
@FlorianWendelborn FlorianWendelborn added the autorebase:non-rebaseable AutoRebase applies this label when a pull request can't be rebased automatically label Aug 22, 2023
@Isokaeder Isokaeder force-pushed the master branch 6 times, most recently from db0f2aa to 78dbab4 Compare May 14, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianWendelborn FlorianWendelborn FlorianWendelborn requested changes

@santiagoballadares santiagoballadares santiagoballadares left review comments

@Isokaeder Isokaeder Isokaeder left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
autorebase:non-rebaseable AutoRebase applies this label when a pull request can't be rebased automatically autorebase:opt-in Apply this label to enable automatic rebasing package:kotti-ui @3yourmind/kotti-ui priority:3-normal Should be fixed soon type:enhancement features, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carsoli @santiagoballadares @FlorianWendelborn @Isokaeder